Enforce that android::base::expected, i.e. Result return values are handled
#1926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re handled Ignoring failures can hide errors. Existing noncompliant uses are marked with a TODO comment. This is currently reported as a warning at `bazel build` time, and a clang-tidy failure at `bazel test` time. As far as I can tell, clang compiler warnings automatically are converted into `clang-diagnostic-*` failures in clang-tidy, which we convert to errors in our clang-tidy tests. Properties of this approach: - Applies only to our GitHub repository, and not the google-internal downstream. This avoids us blocking submission of other changes Google's internal source tree. - Doesn't break `bazel build`, `bazel run`, or `debuild` at the time of compiler updates or active development of new code. - Validated at PR submission time on GitHub by the `run-cvd-unit-tests` action which runs clang-tidy and blocks submission. - Possible to reproduce failures with `bazel test`. Bug: b/471073085
jemoreira
approved these changes
Dec 23, 2025
Member
Author
|
Thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignoring failures can hide errors.
Existing noncompliant uses are marked with a TODO comment.
This is currently reported as a warning at
bazel buildtime, and a clang-tidy failure atbazel testtime. As far as I can tell, clang compiler warnings automatically are converted intoclang-diagnostic-*failures in clang-tidy, which we convert to errors in our clang-tidy tests.Properties of this approach:
bazel build,bazel run, ordebuildat the time of compiler updates or active development of new code.run-cvd-unit-testsaction which runs clang-tidy and blocks submission.bazel test.Bug: b/471073085