Merged
Conversation
1dd2f37 to
90f04eb
Compare
In `bazel_common` and `flogger`, this included temporarily adding a direct dependency on the newest version of `rules_android` so that [`rules_jvm_external` gets the version it needs for Bazel 9](https://github.com/bazel-contrib/rules_jvm_external/pull/1534/changes#diff-6136fc12446089c3db7360e923203dd114b6a1466252e71667c6791c20fe6bdcR7), avoiding this error: ``` ERROR: Traceback (most recent call last): File "/usr/local/google/home/cpovirk/.cache/bazel/_bazel_cpovirk/63abd04538d973afcb7c178098cdeca1/external/rules_android+/rules/android_binary/attrs.bzl", line 68, column 29, in <toplevel> deps = make_deps(DEPS_ALLOW_RULES, DEPS_PROVIDERS, DEPS_ASPECTS), File "/usr/local/google/home/cpovirk/.cache/bazel/_bazel_cpovirk/63abd04538d973afcb7c178098cdeca1/external/rules_android+/rules/android_binary/attrs.bzl", line 35, column 27, in make_deps return attr.label_list( Error in label_list: at index 0 of providers, got element of type NoneType, want Provider WARNING: Target pattern parsing failed. ERROR: Skipping '@google_bazel_common_maven//:pin': error loading package '@@rules_jvm_external++maven+google_bazel_common_maven//': at /usr/local/google/home/cpovirk/.cache/bazel/_bazel_cpovirk/63abd04538d973afcb7c178098cdeca1/external/rules_android+/rules/rules.bzl:45:5: at /usr/local/google/home/cpovirk/.cache/bazel/_bazel_cpovirk/63abd04538d973afcb7c178098cdeca1/external/rules_android+/rules/android_binary/rule.bzl:25:6: initialization of module 'rules/android_binary/attrs.bzl' failed ``` RELNOTES=n/a PiperOrigin-RevId: 874736106
90f04eb to
4380e15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump Bazel to 9.0.0.
In
bazel_commonandflogger, this included temporarily adding a direct dependency on the newest version ofrules_androidso thatrules_jvm_externalgets the version it needs for Bazel 9, avoiding this error:RELNOTES=n/a