fix: ignore the 'B' augmentation character when reading CIE info. #454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
EricRahm
requested changes
Nov 19, 2025
Collaborator
EricRahm
left a comment
EricRahm
left a comment
There was a problem hiding this comment.
Overall lgtm, thanks for the contribution! One small request, one bigger request:
- Can you include a more detailed commit message and reference issue #450?
- We'd like to start including
littests for things like this. There are examples undertests/. Is that something you'd be interested in taking care of?
| ReadEncodedPointer(encoding, true, &entry, nullptr, sink); | ||
| break; | ||
| } | ||
| case 'B': { |
Collaborator
There was a problem hiding this comment.
Makes sense to me, we might also consider handling G while we're at it. I think similarly that's a flag and we can just ignore it. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some compilers emit a B augmentation character that Bloaty does not currently handle. This patch ignores it because it is not useful for binary size analysis and should not break the process.
ref: llvm-mirror/libunwind@0930d6c