[Security Vulnerability] Fix for Server-Side Template Injection (SSTI) via #evaluate#98
Open
hayageek wants to merge 1 commit intogoogle:mainfrom
Open
[Security Vulnerability] Fix for Server-Side Template Injection (SSTI) via #evaluate#98hayageek wants to merge 1 commit intogoogle:mainfrom
hayageek wants to merge 1 commit intogoogle:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EscapeVelocity, does not sanitize user-controlled template variables passed to
Template.evaluate(Map vars). When a template contains the#evaluatedirective, the value of the evaluated variable is parsed and executed as a Velocity template. This allows Server-Side Template Injection (SSTI) and can lead to Remote Code Execution (RCE) via reflection.Description
Mappassed toTemplate.evaluate(Map vars)Parser.javalines 1486–1492:new Parser(new StringReader(value)).parse()andtemplate.render()expression.evaluate(context)returns string → Parser parses string as template →template.render()executes injected directives (e.g. RCE via reflection)#evaluate($var).