Add ruff to the testing

[cclauss]

https://docs.astral.sh/ruff
https://docs.astral.sh/ruff/linter

As suggested at

• ruff rules for comprehensions and performance #420 (comment)

[boomanaiden154]

Can we keep the existing style/pytest files as they were rather than moving everything to pyproject.toml?

[cclauss]

From validate-pyproject README:

With the approval of PEP 517 and PEP 518, the Python community shifted towards a strong focus on standardization for packaging software, which allows more freedom when choosing tools during development and make sure packages created using different technologies can interoperate without the need for custom installation procedures.

This shift became even more clear when PEP 621 was also approved, as a standardized way of specifying project metadata and dependencies.

PEP 621 – Storing project metadata in pyproject.toml was approved in 2020.

[mtrofin]

From validate-pyproject README:

With the approval of PEP 517 and PEP 518, the Python community shifted towards a strong focus on standardization for packaging software, which allows more freedom when choosing tools during development and make sure packages created using different technologies can interoperate without the need for custom installation procedures.

This shift became even more clear when PEP 621 was also approved, as a standardized way of specifying project metadata and dependencies.

PEP 621 – Storing project metadata in pyproject.toml was approved in 2020.

Seems reasonable to move to pyproject.toml. @boomanaiden154, is there a scenario that you're concerned with, that would be broken, or is this (more likely, PR #423) good to go (once the bots are clear)?

[boomanaiden154]

@cclauss You need to update Pipfile.lock too.

[cclauss]

Unfortunately pipenv will not update Pipfile.lock for me on my M1 Mac.

• #Draft: Support MacOS Intel and M1 google-deepmind/reverb#128

Natively and inside Docker a similar error appears:
ERROR: Could not find a version that satisfies the requirement dm-reverb==0.14.0

https://pypi.org/project/dm-reverb/#installation is Linux only but in the Dockerfile container I am running on Linux.

Is it because I am on ARM and not Intel?

---

11.57 Collecting decorator==5.1.1 (from -r
11.57 /tmp/pipenv-gmvmcczu-requirements/pipenv-_e9n8ljz-hashed-reqs.txt (line 6))
11.57   Downloading decorator-5.1.1-py3-none-any.whl (9.1 kB)
11.57 ERROR: Could not find a version that satisfies the requirement dm-reverb==0.14.0
11.57 (from versions: none)
11.57 ERROR: No matching distribution found for dm-reverb==0.14.0
11.57 ERROR: Couldn't install package: {}
11.57  Package installation failed...
------
Dockerfile:5
--------------------
   3 |     WORKDIR /ml-compiler-opt
   4 |     COPY . .
   5 | >>> RUN pip install pipenv && pipenv sync --system && pipenv --clear
   6 |
   7 |     WORKDIR /ml-compiler-opt/compiler_opt/tools
--------------------
ERROR: failed to solve: process "/bin/sh -c pip install pipenv && pipenv sync --system && pipenv --clear" did not complete successfully: exit code: 1

[cclauss]

Is it because I am on ARM and not Intel?

Yes, it is...

• #Draft: Support MacOS Intel and M1 google-deepmind/reverb#128

GitHub Action...

name: dm-reverb
on:
  push:
  pull_request:
  workflow_dispatch:
jobs:
  dm-reverb:
    strategy:
      fail-fast: false
      matrix:
        os: [ ubuntu-24.04, ubuntu-24.04-arm ]  # ARM always fails!!
        python-version: [ "3.8", "3.9", "3.10", "3.11" ]
    runs-on: ${{ matrix.os }}
    steps:
    - uses: actions/setup-python@v5
      with:
        python-version: ${{ matrix.python-version }}
    - run: pip install dm-reverb

If someone can add ruff to Pipfile.lock then I can rebase this PR getting rid of the pipx trick.

[boomanaiden154]

If someone can add ruff to Pipfile.lock then I can rebase this PR getting rid of the pipx trick.

Done. Will land once CI passes.