Open
Conversation
This was referenced Mar 3, 2024
Contributor
Author
|
@XinranTang could you kindly take a look, please? |
Contributor
Author
|
@chensun was this possibly been looked into during last summer of code, also ref kubeflow/pipelines#7512 ; thank you in advance for your feedback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #194
Proposed solution(s)
Taking MLMD's Context string property as example,
S1. modify PostgreSQL index to be ~like:
or derivatives. (requires first
CREATE EXTENSION pg_trgm;)S2. modify PostgreSQL index to be ~like:
making it similar to MySQL behaviour, less ideal because would only be partially helpful on queries longer term.
(S3. a third solution would be to drop the
idx_..._property_stringindexes altogether which seems to be causing the issue, but I don't think is worth considering).This PR
The scope of this PR is to demonstrate S1 in practice,
or discuss alternative approaches.
/cc @XinranTang could you kindly consult with the team and feedback on this, please?