-
Notifications
You must be signed in to change notification settings - Fork 21
Apply fixes for linting issues #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
e615fe8 to
9899e6b
Compare
hassler-google
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Peyton, thanks for your contribution here.
For this PR and #38, the main thing we must figure out is how to handle the difference in the linter and documentation format between this repository and the place from which we publish changes here.
For example, the upstream repository uses a variant of pylint for linting instead of ruff, and we will need to maintain a version with pylint: https://google.github.io/styleguide/pyguide.html.
For this PR, do most of the changes go away if we set a linter check using pylint instead of ruff --fix ?
|
That said, many of the changes that you see here come from the |
|
@peytondmurray @andrewfulton9 can I please get your approval of my changes on this PR? |
|
Let's hold off on merging until we get tests running, which are currently blocked by the build being broken. |
|
I may just be missing something, but where are the configurations? It looks like the pyproject.toml is empty and I don't see any other linting configurations here. |
This PR applies pre-commit fixes across the entire repository in preparation for merging #40. Although this touches many files, the fixes are all safe, and were generated with
ruff --fix. Most of these are end-of-file and trailing whitespace fixes, but there are also a few places imports were reordered, and where f-strings were used in place of calls toformat().