Remove Tokio related channel stuff#484
Open
stevefan1999-personal wants to merge 6 commits intogoogle:mainfrom
Open
Remove Tokio related channel stuff#484stevefan1999-personal wants to merge 6 commits intogoogle:mainfrom
stevefan1999-personal wants to merge 6 commits intogoogle:mainfrom
Conversation
|
Is there still interest in this? I do not understand why the test suite is still pending a week after any changes. From what I can tell, this PR changes much more than just replacing channels. If I prepare a PR to replace the channels, is there a chance of getting it merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR just replaces Tokio channel/sync stuff using futures equivalent, which means reserve permit support is unfortunately gone (there is no equivalent of it). However, it should be one step further to making tarpc runtime-agnostic, after removing the delay queue dependency on Tokio. All tests (except reserve which was removed) still passed.
Salvaged from the code rot in #385