Conversation
chiphogg
left a comment
chiphogg
left a comment
There was a problem hiding this comment.
Thanks for adding this functionality!
|
|
||
| " wait to remove file | ||
| function! s:WaitToRemoveFile(file) | ||
| sleep 1000m |
There was a problem hiding this comment.
It looks like this adds a 1-second delay, which wasn't here before. Is this really necessary?
There was a problem hiding this comment.
for me, without a delay, safari will not able to read the file before it has been deleted. (I use vim 8 btw)
I was considered to add a new variable to this plugin. maybe open_browser_delay, defaults to false?
how do you think about this?
There was a problem hiding this comment.
Adding a new plugin variable sounds good. You could also make it a floating point variable -- say, open_browser_delay_seconds -- and default it to 0.0. Be sure to add documentation in flags.vim in the same way that the others are documented. It would be great if you could also re-run vimdoc to update the online help.
| endfunction | ||
|
|
||
| " wait to remove file | ||
| function! s:WaitToRemoveFile(file) |
There was a problem hiding this comment.
If we really need the delay, how about s:RemoveFileAfterDelay(file, delay).
3 participants
Hi, I just made a patch for osx, please check and let me know if anything else required, thanks.