Skip to content

netblocks: fix import path in skill + readme examples#349

Merged
ruofeidu merged 4 commits into
google:mainfrom
salmanmkc:fix/netblocks-import-path-cdn
Jun 6, 2026
Merged

netblocks: fix import path in skill + readme examples#349
ruofeidu merged 4 commits into
google:mainfrom
salmanmkc:fix/netblocks-import-path-cdn

Conversation

@salmanmkc
Copy link
Copy Markdown
Contributor

@salmanmkc salmanmkc commented Jun 6, 2026

'xrblocks/addons/netblocks/src' returns 404 on cdn.jsdelivr.net/gh/google/xrblocks@build/... because browser importmaps don't have node-style index resolution. needs the explicit /index.js.

caught while testing an eval harness against the canvas-gem skill setup, every with-skill run failed in headless chromium with net::ERR_ABORTED on the netblocks import.

the netblocks README already uses the /index.js form one block down (line 80), so this just makes the rest of the file consistent. same for the skill.

xrblocks/addons/netblocks/src returns 404 on the @build cdn because browser importmaps do not have node-style index resolution. needs the explicit /index.js.

the netblocks README already uses the /index.js form one block down, so this just makes the rest of the file consistent. same for the skill.
salmanmkc added 2 commits June 6, 2026 11:22
missed two more instances of the bare-directory import in the in-tree SKILL.md when fixing the same bug across the canvas-gem skill + readme. caught by an eval-driven scan that curl-verified every xrblocks/addons/<name> import against the @build cdn.
ci surfaced this after the last commit. prettier wanted to reformat the line lengths around the import-path edit.
@ruofeidu ruofeidu merged commit c08d1f9 into google:main Jun 6, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants