Skip to content

Conversation

@jonasstenberg
Copy link

The ChatBase constructor accepts comprehensiveHistory and curatedHistory parameters but never uses them—both fields are always initialized as empty ArrayList instances regardless of what's passed in.

The Bug

// Before (broken)
ChatBase(List comprehensiveHistory, List curatedHistory) {
  this.comprehensiveHistory = new ArrayList<>();
  this.curatedHistory = new ArrayList<>();
}

The Fix

// After (fixed)
ChatBase(List comprehensiveHistory, List curatedHistory) {
  this.comprehensiveHistory = comprehensiveHistory;
  this.curatedHistory = curatedHistory;
}

Impact

This bug would prevent any functionality that relies on initializing a chat session with existing conversation history from working correctly.

@google-cla
Copy link

google-cla bot commented Jan 19, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

The ChatBase constructor was ignoring its parameters and always initializing comprehensiveHistory and curatedHistory as empty lists.
This prevented any pre-existing conversation history from being used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant