-
Notifications
You must be signed in to change notification settings - Fork 99
chore(deps): update dependency virtualenv to v20.36.1 [security] #1477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore(deps): update dependency virtualenv to v20.36.1 [security] #1477
Conversation
Summary of ChangesHello @renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the virtualenv dependency to version 20.36.1 to address the security vulnerability GHSA-597g-3phw-6986. The update to version 20.36.1 is correct and resolves the vulnerability, as confirmed by the official GitHub Security Advisory and the virtualenv release notes. The code change is correct. It is worth noting that the vulnerability summary in the PR description appears to contain incorrect information, stating the fix is in 20.36.2, which could cause confusion. No changes are required for this PR.
This PR contains the following updates:
==20.34.0→==20.36.1GitHub Vulnerability Alerts
CVE-2026-22702
Impact
TOCTOU (Time-of-Check-Time-of-Use) vulnerabilities in
virtualenvallow local attackers to perform symlink-based attacks on directory creation operations. An attacker with local access can exploit a race condition between directory existence checks and creation to redirect virtualenv's app_data and lock file operations to attacker-controlled locations.Affected versions: All versions up to and including 20.36.1
Affected users: Any user running
virtualenvon multi-user systems where untrusted local users have filesystem access to shared temporary directories or whereVIRTUALENV_OVERRIDE_APP_DATApoints to a user-writable location.Attack scenarios:
Patches
The vulnerability has been patched by replacing check-then-act patterns with atomic
os.makedirs(..., exist_ok=True)operations.Fixed in: PR #3013
Versions with the fix: 20.36.2 and later
Users should upgrade to version 20.36.2 or later.
Workarounds
If you cannot upgrade immediately:
VIRTUALENV_OVERRIDE_APP_DATApoints to a directory owned by the current user with restricted permissions (mode 0700)virtualenvin shared temporary directories where other users have write accessReferences
Release Notes
pypa/virtualenv (virtualenv)
v20.36.1Compare Source
What's Changed
Full Changelog: pypa/virtualenv@20.36.0...20.36.1
v20.36.0Compare Source
What's Changed
errno.EMFILEinstead ofstrerrorby @pltrz in #3001--pythonflag. by @rahuldevikar in #3008New Contributors
Full Changelog: pypa/virtualenv@20.35.3...20.36.0
v20.35.4Compare Source
What's Changed
New Contributors
Full Changelog: pypa/virtualenv@20.35.3...20.35.4
v20.35.3Compare Source
What's Changed
Full Changelog: pypa/virtualenv@20.35.1...20.35.3
v20.35.2Compare Source
What's Changed
Full Changelog: pypa/virtualenv@20.35.1...20.35.2
v20.35.1Compare Source
What's Changed
Full Changelog: pypa/virtualenv@20.34.0...20.35.1
v20.35.0Compare Source
What's Changed
Full Changelog: pypa/virtualenv@20.34.0...20.35.0
Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.