feat: HTTP Route Support #2293
feat: HTTP Route Support #2293
Conversation
theSuess
force-pushed
the
push-wrysouumqzvt
branch
3 times, most recently
from
8acb2a0 to
87a6cac
Compare
github-actions
bot
added
the
documentation
theSuess
force-pushed
the
push-wrysouumqzvt
branch
from
3e34acd to
0991d9b
Compare
Co-Authored-By: Aleksei Sviridkin <[email protected]> Co-Authored-By: sure <[email protected]>
theSuess
force-pushed
the
push-wrysouumqzvt
branch
from
0991d9b to
64bf7c7
Compare
theSuess
requested review from
Baarsgaard,
hubeadmin,
ishanjainn,
nissessenap,
pb82 and
weisdd
as code owners
|
E2E tests do not offer any advantage to integration tests in this case as we can fully cover everything in there so I omitted them for now |
weisdd
left a comment
weisdd
left a comment
There was a problem hiding this comment.
I've added a couple of minor recommendations (not affecting the functionality itself), the rest is great.
| return r.reconcileRoute(ctx, cr, vars, scheme) | ||
| } | ||
|
|
||
| if cr.Spec.HTTPRoute != nil { |
There was a problem hiding this comment.
At first, I thought we should extend the IngressReconciler struct in the same way as for OpenShift (to add a field hasGatewayAPI), but it's actually smarter to have things as they are, so the operator can potentially start successfully reconciling instances with HTTPRoutes once the CRD is installed without the need for immediate restart.
Let's add a comment stating that it's all intentional, so nobody gets confused when revising the code later.
| mgrOptions.Cache.ByObject[&routev1.Route{}] = cacheLabelConfig | ||
| } | ||
|
|
||
| if hasGatewayAPI { |
There was a problem hiding this comment.
In case of a delayed CRD installation, caching will not get fine-tuned for HTTPRoutes. I think we should add a log message saying something along the lines: "Caching fine-tuning is skipped for HTTPRoutes, because gateway.networking.k8s.io CRD is not currently present in the cluster".
2 participants
This PR combines the best parts of #2283 and #2026.
Only adds management of
HTTPRouteresources. Decisions on how to handlePreferIngressare to be made in #2284.