Refactor serde and ScalarValue relations#985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for #975
Synopsis
This PR refactors the way
serdeis paired withScalarValues. Previously,ScalarValueexposedVisitorassociated type forInputValue<T>being able to delegate scalar value deserialization,#[derive(GraphQLScalarValue)]was always providing aSerializeimplementation. Such approach was causing issues for implementingScalarValuefor foreign types, because in mostde::Visitortypes are private and not exposed, which makes us to duplicate deserialization logic in our code, and user looses control over serialization.Solution
The refactored approach requires only
T: Deserializeforimpl Deserialize for InputValue<T>, and, additionally, removesimpl Serializefrom the code generated by#[derive(GraphQLScalarValue)]. This allows:Deserializeimpls for foreign types and require to do squats with exposingVisitor;Checklist