Enforce pVACvector pathfinder preconditions#1380
Open
maksimf wants to merge 2 commits intogriffithlab:stagingfrom
Open
Enforce pVACvector pathfinder preconditions#1380maksimf wants to merge 2 commits intogriffithlab:stagingfrom
maksimf wants to merge 2 commits intogriffithlab:stagingfrom
Conversation
Handle single-peptide runs without junction edges by emitting stable NA score metadata instead of dividing by zero, and add a regression test to prevent future crashes.
Contributor
|
|
Make find_optimal_path fail fast when called with an invalid graph and update the regression test to assert the expected exception for out-of-contract invocation.
Author
|
@susannasiebert Thank you Susanna, is this better? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
find_optimal_pathto ensure it is only called with a graph that passescheck_graph_valid.find_optimal_pathis invoked with an invalid graph state.