Skip to content

Conversation

@yhakbar
Copy link
Collaborator

@yhakbar yhakbar commented Aug 14, 2025

Description

Explicitly maps every legacy flag that's being removed to the modern equivalent.

TODOs

Read the Gruntwork contribution guidelines.

  • I authored this code entirely myself
  • I am submitting code based on open source software (e.g. MIT, MPL-2.0, Apache)]
  • I am adding or upgrading a dependency or adapted code and confirm it has a compatible open source license
  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added / Removed / Updated [X].

Migration Guide

Summary by CodeRabbit

  • Documentation
    • Added a “CLI Flag Migration Table” to the CLI redesign migration guide, mapping legacy --terragrunt-* flags to their new equivalents (e.g., --terragrunt-config → --config, --terragrunt-working-dir → --working-dir).
    • Published in both documentation variants for consistency and ease of reference; existing environment variable guidance remains unchanged.
    • Helps users quickly update scripts and commands during migration; no product behavior changes.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 14, 2025

📝 Walkthrough

Walkthrough

Adds a “CLI Flag Migration Table” section to two migration guide files, mapping old Terragrunt CLI flags (prefixed with --terragrunt-) to new non-prefixed equivalents. Placement is after notes about the new flag names and before environment variable guidance. No code or behavioral changes.

Changes

Cohort / File(s) Summary of modifications
Starlight docs migration guide
docs-starlight/src/content/docs/06-migrate/03-cli-redesign.md
Inserted “CLI Flag Migration Table” detailing one-to-one mappings from old --terragrunt-* flags to new names; positioned after the CLI reference note and before environment-variable guidance.
Hugo docs migration guide
docs/_docs/06_migration_guides/03-cli-redesign.md
Added identical “CLI Flag Migration Table” with comprehensive flag mappings; placed after the note about new flag names and before the environment variables section.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested reviewers

  • denis256
  • levkohimins
  • Resonance1584

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch docs/updating-migration-guide-for-85

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vercel
Copy link

vercel bot commented Aug 14, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
terragrunt-docs Ready Preview Comment Aug 14, 2025 9:52pm

@yhakbar yhakbar marked this pull request as ready for review August 14, 2025 22:00
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
docs-starlight/src/content/docs/06-migrate/03-cli-redesign.md (1)

64-122: Call out non-trivial renames with short notes for accuracy

A few mappings aren’t purely cosmetic removals of the terragrunt- prefix and may have scope/behavior nuances (e.g., debug → inputs-debug; ignore-dependency-errors → queue-ignore-errors; fail-on-state-bucket-creation → backend-require-bootstrap). Adding a brief note after the table will prevent misinterpretation.

Apply this minimal diff to add a short “Notes” section immediately after the table:

 | `--terragrunt-no-destroy-dependencies-check` | `--no-destroy-dependencies-check` |
 |
+Note: Some renames are not purely cosmetic and may differ slightly in scope or behavior:
+- `--terragrunt-debug` → `--inputs-debug`: the flag now targets inputs processing rather than global debug.
+- `--terragrunt-ignore-dependency-errors` → `--queue-ignore-errors`: the flag is scoped to queue/graph execution behavior.
+- `--terragrunt-fail-on-state-bucket-creation` → `--backend-require-bootstrap`: explicit bootstrap is required instead of implicitly creating backend resources.
+
docs/_docs/06_migration_guides/03-cli-redesign.md (1)

69-127: Flag important behavior changes with brief notes

A few entries are not pure prefix removals and could surprise users without context (e.g., debug → inputs-debug; ignore-dependency-errors → queue-ignore-errors; fail-on-state-bucket-creation → backend-require-bootstrap). Add a short note block right after the table.

Apply this minimal diff to include clarifying notes:

 | `--terragrunt-no-destroy-dependencies-check` | `--no-destroy-dependencies-check` |
 |
+Note: Some renames are not purely cosmetic and may differ slightly in scope or behavior:
+- `--terragrunt-debug` → `--inputs-debug`: the flag now targets inputs processing rather than global debug.
+- `--terragrunt-ignore-dependency-errors` → `--queue-ignore-errors`: the flag is scoped to queue/graph execution behavior.
+- `--terragrunt-fail-on-state-bucket-creation` → `--backend-require-bootstrap`: explicit bootstrap is required instead of implicitly creating backend resources.
+
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these settings in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 0209de0 and f995a6c.

📒 Files selected for processing (2)
  • docs-starlight/src/content/docs/06-migrate/03-cli-redesign.md (1 hunks)
  • docs/_docs/06_migration_guides/03-cli-redesign.md (1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
docs-starlight/**/*.md*

⚙️ CodeRabbit Configuration File

Review the documentation for clarity, grammar, and spelling. Make sure that the documentation is easy to understand and follow. There is currently a migration underway from the Jekyll based documentation in docs to the Starlight + Astro based documentation in docs-starlight. Make sure that the docs-starlight documentation is accurate and up-to-date with the docs documentation, and that any difference between them results in an improvement in the docs-starlight documentation.

Files:

  • docs-starlight/src/content/docs/06-migrate/03-cli-redesign.md
docs/**/*.md

⚙️ CodeRabbit Configuration File

Review the documentation for clarity, grammar, and spelling. Make sure that the documentation is easy to understand and follow. There is currently a migration underway from the Jekyll based documentation in docs to the Starlight + Astro based documentation in docs-starlight. Whenever changes are made to the docs directory, ensure that an equivalent change is made in the docs-starlight directory to keep the docs-starlight documentation accurate.

Files:

  • docs/_docs/06_migration_guides/03-cli-redesign.md
🧠 Learnings (1)
📚 Learning: 2025-04-17T13:02:28.098Z
Learnt from: yhakbar
PR: gruntwork-io/terragrunt#4169
File: cli/commands/hcl/validate/cli.go:29-60
Timestamp: 2025-04-17T13:02:28.098Z
Learning: Avoid shadowing imported packages with local variables in Go code, such as using a variable named `flags` when the `github.com/gruntwork-io/terragrunt/cli/flags` package is imported. Use more specific variable names like `flagSet` instead.

Applied to files:

  • docs-starlight/src/content/docs/06-migrate/03-cli-redesign.md
  • docs/_docs/06_migration_guides/03-cli-redesign.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
  • GitHub Check: Build (darwin/amd64)
  • GitHub Check: Build (linux/arm64)
  • GitHub Check: Build (linux/amd64)
  • GitHub Check: Test (CAS)
  • GitHub Check: Test (Provider Cache Dir with Tofu)
  • GitHub Check: Test (AWS with Latest Terraform)
  • GitHub Check: Test (Provider Cache Server with Latest Terraform)
  • GitHub Check: Test (AWS with Latest OSS Terraform)
  • GitHub Check: Test (AWS Tofu)
  • GitHub Check: Test (Fixtures with Latest Terraform)
  • GitHub Check: Test (macos)
🔇 Additional comments (5)
docs-starlight/src/content/docs/06-migrate/03-cli-redesign.md (3)

64-122: Great addition: clear, high-signal mapping table

The table adds immediate, practical value for users migrating from legacy flags to the new names. Placement is spot-on and formatting reads well.


64-122: CLI Flag Migration Table Verification Needed

The automated extraction script failed due to environment limitations. Please manually ensure the following before merging:

  • Scan the repo for any remaining --terragrunt-* flags (e.g. grep -R -- '--terragrunt-' .) and confirm each is listed in the migration table.
  • Verify every “New Flag” in the table appears in your docs/reference directories (docs-starlight/src/content/docs/docs/reference and docs/_docs/06_migration_guides).
  • Confirm that the CLI Flag Migration Table in Starlight (docs-starlight/.../03-cli-redesign.md) is identical to the one in Jekyll (docs/_docs/06_migration_guides/03-cli-redesign.md).

64-122: --queue-include-units-reading flag is correctly spelled and widely used
The exact flag name appears in:

  • cli/commands/run/flags.go (definition and deprecation alias)
  • Integration tests (test/integration_units_reading_test.go)
  • Reference docs under /docs/reference/cli-options/ and /docs/reference/cli/commands/run
  • Migration guide (docs-starlight/src/content/docs/06-migrate/03-cli-redesign.md)

No typo detected—no changes needed.

docs/_docs/06_migration_guides/03-cli-redesign.md (2)

69-127: Nicely structured mapping improves the migration story

The dedicated table is helpful and mirrors the Starlight doc, keeping both sites consistent.


69-127: Double-check --queue-include-units-reading

The “reading” suffix stands out as potentially unintended. Please validate the spelling against the CLI and reference docs, and align the table accordingly if needed.

Run the same verification script I shared in the Starlight comment from the repo root; it also checks that both tables are identical and flags missing or unused mappings.

@denis256 denis256 merged commit 5fbbdd8 into main Aug 15, 2025
49 of 53 checks passed
@denis256 denis256 deleted the docs/updating-migration-guide-for-85 branch August 15, 2025 11:46
@coderabbitai coderabbitai bot mentioned this pull request Aug 15, 2025
6 tasks
@regressEdo
Copy link

what about --terragrunt-quiet, I don't see it as a part of the list, nevertheless it begins with --terragrunt-

@yhakbar
Copy link
Collaborator Author

yhakbar commented Aug 15, 2025

what about --terragrunt-quiet, I don't see it as a part of the list, nevertheless it begins with --terragrunt-

Great question! It is not a CLI flag, and will not be impacted by breaking changes on the road to 1.0. We may consider deprecating the run_cmd HCL function in favor of one that has different semantics (we've been thinking of replacing it with an exec HCL function that is quiet by default, and allows users to opt into verbosity with a --verbose flag), but that's something we'd be considering on the timeline of a 2.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants