fix(deps): drop swift-sdk fork branch for official tagged release#31
Merged
Conversation
OCCTMCP (a tagged, released package) depended on the gsdali/swift-sdk fork branch `add-value-numbervalue` — a moving, non-reproducible reference whose only delta from upstream was a single `Value.numberValue` computed property (upstream PR modelcontextprotocol/swift-sdk#226, still open). Switch to the official modelcontextprotocol/swift-sdk (`from: "0.11.0"`, resolves to 0.12.1) and back-port `Value.numberValue` locally in Value+NumberValue.swift. Behavior is identical — the back-port is a verbatim copy of the proposed accessor — but the dependency is now a reproducible version pin instead of a fork branch that could move or disappear. Delete Value+NumberValue.swift (and nothing else) once the SDK ships the property upstream. Build clean; all 28 tests pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
OCCTMCP — a tagged, released package (currently v1.4.0) — depended on the
gsdali/swift-sdkfork branchadd-value-numbervalue:A branch reference is a moving, non-reproducible pin: consumers and CI get whatever is on the branch at resolve time, and it breaks if the fork branch is ever rebased or deleted. The branch's only delta from upstream
mainis a singleValue.numberValuecomputed property (proposed upstream in modelcontextprotocol/swift-sdk#225, PR #226 — still open).Fix
modelcontextprotocol/swift-sdk(from: "0.11.0", resolves to 0.12.1). The package identity staysswift-sdk, so all.product(name: "MCP", package: "swift-sdk")references are unchanged.Value.numberValuelocally inSources/OCCTMCPCore/Value+NumberValue.swift— a verbatim copy of the proposed accessor (coerces.int/.double→Double).Server.swiftconsumes it in ~12 places (coordinates, tolerances, material params).Verification
Package.resolvednow pinsswift-sdkat version 0.12.1 (revision-locked) instead of a branch.swift buildclean (0 errors); all 28 tests pass.🤖 Generated with Claude Code