Skip to content

Makefile and build procedure updates for recent (RH) Linux#10

Closed
maxieds wants to merge 1 commit intomasterfrom
math-mulberry-makefile-build-changes
Closed

Makefile and build procedure updates for recent (RH) Linux#10
maxieds wants to merge 1 commit intomasterfrom
math-mulberry-makefile-build-changes

Conversation

@maxieds
Copy link

@maxieds maxieds commented Oct 8, 2020

This PR should integrate the Makefile changes made for the math-mulberry applications into the master branch of the PMFE code. Note that this PR in part replaces the initial larger merge request documented in issue #3.

@maxieds maxieds changed the title Math mulberry Makefile and build procedure updates for recent (RH) Linux Makefile and build procedure updates for recent (RH) Linux Oct 8, 2020
Copy link

@ceheitsch ceheitsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maxie, would you please explain why the "-frounding-math" flag is needed?

@maxieds
Copy link
Author

maxieds commented Oct 23, 2020

@ceheitsch
I do not remember exactly what led me to add that option. The gcc docs explain what that flag is used to add:

-frounding-math
Disable transformations and optimizations that assume default floating-point rounding behavior. 
This is round-to-zero for all floating point to integer conversions, and round-to-nearest for all other 
arithmetic truncations. This option should be specified for programs that change the FP rounding 
mode dynamically, or that may be executed with a non-default rounding mode. This option disables 
constant folding of floating-point expressions at compile time (which may be affected by rounding
 mode) and arithmetic transformations that are unsafe in the presence of sign-dependent rounding 
modes.

The default is -fno-rounding-math.

This option is experimental and does not currently guarantee to disable all GCC optimizations that 
are affected by rounding mode. Future versions of GCC may provide finer control of this setting 
using C99’s FENV_ACCESS pragma. This command-line option will be used to specify the default 
state for FENV_ACCESS.

@ceheitsch
Copy link

@maxieds It seems more risky than needed to use experimental options. I've also opened a separate issue about the possibility of using cmake (#22). On superficial inspection, it seems to address many of the compilation annoyances in a more robust fashion. Would you please look into it more carefully? Thanks!

@maxieds
Copy link
Author

maxieds commented Dec 2, 2020

The contents of this pull request are updated in the more recent PR #26 (the Makefile has been renamed there to remove confusion with the new intended CMakeLists build procedure).

@maxieds maxieds closed this Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants