Skip to content

Commit d6dfba9

Browse files
committed
Fix Settings page active values unreadable in light mode
Use bg-card and text-card-foreground theme classes instead of hardcoded emerald colors to ensure proper contrast in both light and dark modes.
1 parent d403206 commit d6dfba9

File tree

2 files changed

+10
-7
lines changed

2 files changed

+10
-7
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
77

88
## [Unreleased]
99

10+
### Fixed
11+
- **Settings page**: Active configuration values now readable in light mode with proper background colors
12+
1013
## [v0.3.0] - 2025-11-18
1114

1215
### Added

frontend/src/pages/settings/SettingsPage.tsx

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -344,7 +344,7 @@ export function SettingsPage() {
344344
<div className="flex justify-center">
345345
<div className={`inline-flex items-center justify-center px-3 py-1.5 rounded-full ${
346346
activeField === 'default' && isSet(defaultValue)
347-
? 'bg-green-100 dark:bg-green-950 border border-green-500'
347+
? 'bg-card text-card-foreground border border-emerald-500'
348348
: ''
349349
}`}>
350350
<ValueDisplay value={defaultValue} />
@@ -361,7 +361,7 @@ export function SettingsPage() {
361361
{setting.file_value !== null ? (
362362
<div className={`inline-flex items-center justify-center px-3 py-1.5 rounded-full ${
363363
activeField === 'file_value'
364-
? 'bg-green-100 dark:bg-green-950 border border-green-500'
364+
? 'bg-card text-card-foreground border border-emerald-500'
365365
: ''
366366
}`}>
367367
<ValueDisplay value={setting.file_value} />
@@ -383,10 +383,10 @@ export function SettingsPage() {
383383
// Two line case (pending restart)
384384
<>
385385
<div className="flex items-center justify-center gap-2">
386-
<div className="inline-flex items-center justify-center px-3 py-1.5 rounded-full gap-1.5 bg-blue-100 dark:bg-blue-950 border border-blue-500">
386+
<div className="inline-flex items-center justify-center px-3 py-1.5 rounded-full gap-1.5 bg-card text-card-foreground border border-blue-500">
387387
<RefreshCw className="w-3.5 h-3.5 text-blue-600 dark:text-blue-400" />
388388
{setting.file_value !== null ? (
389-
<ValueDisplay value={setting.file_value} />
389+
<span className="font-mono text-sm">{String(setting.file_value)}</span>
390390
) : (
391391
<CircleDashed className="w-4 h-4 text-muted-foreground" />
392392
)}
@@ -404,7 +404,7 @@ export function SettingsPage() {
404404
<span className="text-muted-foreground">Current:</span>
405405
<div className={`inline-flex items-center justify-center px-2 py-0.5 rounded-full ${
406406
activeField === 'file_value_original'
407-
? 'bg-green-100 dark:bg-green-950 border border-green-500'
407+
? 'bg-card text-card-foreground border border-emerald-500'
408408
: ''
409409
}`}>
410410
<span className="font-mono text-xs">{String(setting.file_value_original)}</span>
@@ -422,7 +422,7 @@ export function SettingsPage() {
422422
{setting.env_value !== null ? (
423423
<div className={`inline-flex items-center justify-center px-3 py-1.5 rounded-full ${
424424
activeField === 'environment'
425-
? 'bg-green-100 dark:bg-green-950 border border-green-500'
425+
? 'bg-card text-card-foreground border border-emerald-500'
426426
: ''
427427
}`}>
428428
<span className="font-mono text-sm font-medium">{String(setting.env_value)}</span>
@@ -528,7 +528,7 @@ export function SettingsPage() {
528528
{/* Legend */}
529529
<div className="mt-4 flex items-center gap-4 text-xs text-muted-foreground flex-wrap">
530530
<div className="flex items-center gap-2">
531-
<div className="w-4 h-4 rounded-full bg-green-100 dark:bg-green-950 border border-green-500" />
531+
<div className="w-4 h-4 rounded-full bg-card border border-emerald-500" />
532532
<span>Active value (currently in use)</span>
533533
</div>
534534
<div className="flex items-center gap-2">

0 commit comments

Comments
 (0)