-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Capture_The_Base #3396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capture_The_Base #3396
Conversation
|
Hello, please check our PR checklist here: https://github.com/hackclub/sprig/blob/main/.github/PULL_REQUEST_TEMPLATE.md |
|
Oops, I see. |
|
Ok, I think I'm done. |
|
https://github.com/hackclub/sprig/pull/3396/files Please double check your files at this link, it looks like your changes did not go through for some reason? Whenever the files are updated, it will show up in that link |
|
Is it? I see clearly my file games/Capture The Base.js |
|
It still looks like you are missing the metadata tags, and also your filename still has spaces. Once you change that we can get started with review! |
|
I fixed everything! |
|
It looks like you are still missing the description, can you copy and paste exactly like this, and then add your tags? |
|
I added description now. :) |
|
OK metadata looks good, a reviewer will take a look at your game soon! |
|
OK, just played your game and I love the concept, seems like it would be very fun!! however it is pretty simple. Can you add some more unique game mechanics? |
|
Yeah I could, just don't know what, don't have enough buttons :) |
|
Maybe add powerups, or shields, maybe new maps, maybe enemies or something? idk use your imagination :) |
Added details about obstacles in the game description.
|
Ok. I added: |
|
Thanks for idea of enemies!) |
|
Also, I checked out your website, cool, however I wanted to report a bug: If you click home (for some reason) on microsoft edge the canvas doesn't fully load, and half the page is white Just thought that it would be easier to tell you here) |
|
WhatWare? Are you there? |
|
sorry, been a busy week for me and im the only reviewer 😭 |
|
also that bug is very strange, i'll look into it if i ever use windows again lol |
whatwareweb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok just took a look at the game, love it! again the artwork is really nice
fix tags
|
Thanks for your submission! If you're a teen, you can get your Sprig here! sprig-order.hackclub.dev Hack Clubbers would love to see this! Just post a link and 1-2 sentences talking about your game to our #ship channel |
|
Cool! Could you add this to my game? |
|
Also, I see now I'm a contributor, do I have right to update my game myself? |
Your checklist for this pull request
Leolevd
Author:
LeoLevd
About your game
What is your game about?
This 2P game is about Fire and Water.
You need to get to your opponent's base before your opponent does the same.
There are two obstacles though.
How do you play your game?
P1: WASD to move, get to the base labeled '2'
P2: IJKL to move, get to the base labeled '1'
Code
Check off the items that are true.
/gamesdirectory.-s, or_s.Image (If an image is used)
/games/imgdirectory.