updated cohesiveenergy#953
Open
nicktbrr wants to merge 1 commit intohackingmaterials:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Update Thermo Featurizers for Modern
mp-apiClientDescription
This PR resolves a series of
AttributeErrorexceptions that occur when using theCohesiveEnergyandCohesiveEnergyMPfeaturizers with modern versions ofpymatgenandmp-api. The errors are caused bymatminercalling deprecated and removed functions from the old Materials Project API client.This fix updates the featurizers to use the new, official
mp-apiclient, restoring their functionality.Changes Made
matminer/featurizers/composition/thermo.pyfrom pymatgen.ext.matproj import MPResterwith the correctfrom mp_api.client import MPRester.CohesiveEnergy.featurizeto usempr.thermo.search()to correctly fetch formation energies.CohesiveEnergyMP.featurizeto use the modern two-step workflow: first finding thematerial_idwithmpr.materials.search()and then retrieving the pre-calculated value withmpr.get_cohesive_energy().pyproject.tomlmp-apias a core dependency, as it is now required for these featurizers to function.