Added the functionality to get the total time spent by the user in a session#189
Open
ymaheshwari1 wants to merge 1 commit intoharsh7in:masterfrom
Open
Added the functionality to get the total time spent by the user in a session#189ymaheshwari1 wants to merge 1 commit intoharsh7in:masterfrom
ymaheshwari1 wants to merge 1 commit intoharsh7in:masterfrom
Conversation
Kajol-Kumari
requested changes
Oct 3, 2020
Collaborator
Kajol-Kumari
left a comment
Kajol-Kumari
left a comment
There was a problem hiding this comment.
@ymaheshwari1 functionality looks fine but may I get a demo of where we are actually using this calculated time spend by the user during a session?
Contributor
Author
|
@Kajol-Kumari Currently I am just logging the session time. I am not showing it to the user. |
Kajol-Kumari
approved these changes
Oct 9, 2020
Collaborator
Kajol-Kumari
left a comment
Kajol-Kumari
left a comment
There was a problem hiding this comment.
The functionality LGTM 👍
But would like know how we are going to use it for showing stats :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #140
Proposed Changes
To find the time the user spent on the site in a session