[Fixes #206] Added comments section for Blog#208
[Fixes #206] Added comments section for Blog#208Vrindagupta6828 wants to merge 1 commit intoharsh7in:masterfrom
Conversation
|
@harsh-9in Please review my pr. |
harsh7in
left a comment
harsh7in
left a comment
There was a problem hiding this comment.
Hey @Vrindagupta6828 This feature looks quite good by there is some changes
- Change the name field to the foreign key of the user so that it automatically add the logines in username
- for body use charfield of max length 500 instead of text field.
Then it it good to go.
|
@harsh-9in ok sure... |
|
@harsh-9in That would require user to be logged in to post a comment is that ok? |
|
@harsh-9in I tried to make the user a foreign key but it is showing many errors |
|
@harsh-9in I asked some doubt if you could please guide me. |
Sorry for the late reply I have seen this issue I Will tell you the sol soon. |
Did you see the solution? |
|
I am trying to solve it, wait till tonight, or I will merge it. |
|
Ohk thanks |
|
@harsh-9in Any update? Once you merge this pr only then can i work on the reply one |
reply one is not our priority even if it got merge. |
harsh7in
left a comment
harsh7in
left a comment
There was a problem hiding this comment.
Plz remove conflicts then it is good to go
|
@harsh-9in What are the conflicts i am unable to resolve it |
2 participants
Related Issuse or bug
Added comments
Fixes: #206
Proposed Changes
I have made changes in many files namely models.py,views.py,forms.py etc.
Screenshots
Updated
:--------------------: |:--------------------:
**
**|