Add a note for the disk removal rejection #921
Conversation
Adding a note in the beginning of the Remove disks section to mention that in case the disk to be removed hosts the last replica, deletion of thedisk will be rejected Signed-off-by: Martin Dekov <[email protected]>
github-actions
bot
requested review from
akashraj4261,
dariavladykina and
jillian-maroket
martindekov
requested review from
Vicente-Cheng,
WebberHuang1118 and
w13915984028
Co-authored-by: akashraj4261 <[email protected]> Signed-off-by: Martin Dekov <[email protected]>
|
Thanks @akashraj4261 addressed |
|
w13915984028
left a comment
w13915984028
left a comment
There was a problem hiding this comment.
LGTM regarding the technical description, thanks.
BTW: for the wording, please wait for the doc experts' approval.
dariavladykina
left a comment
dariavladykina
left a comment
There was a problem hiding this comment.
Hi, please see a linguistic suggestion for this paragraph. Thanks!
Co-authored-by: Daria Vladykina <[email protected]> Signed-off-by: Martin Dekov <[email protected]>
martindekov
requested review from
akashraj4261,
dariavladykina and
w13915984028
WebberHuang1118
left a comment
WebberHuang1118
left a comment
There was a problem hiding this comment.
We should mention the known issue for LH v2 engine harvester/harvester#3344 (comment)
|
@WebberHuang1118 do you think it should be an additional note, or add as part of this one ? |
Signed-off-by: Martin Dekov <[email protected]>
|
Added as part last sentence in the same note. Let me know if it makes sense. |
Co-authored-by: Webber Huang <[email protected]> Signed-off-by: Martin Dekov <[email protected]>
Signed-off-by: Martin Dekov <[email protected]>
martindekov
requested review from
WebberHuang1118,
albinsun and
w13915984028
albinsun
left a comment
albinsun
left a comment
There was a problem hiding this comment.
LGTM
@WebberHuang1118 it should be ok from LH perspective, do you think it's ok for harvester users?
| :::note | ||
|
|
||
| The replica data would be rebuilt to another disk automatically to keep the high availability. | ||
| The replica data would be rebuilt to another disk automatically to keep the high availability. There is a known issue on v2 where single replicated volume will be attempted |
There was a problem hiding this comment.
is this expanded note dedicated for head branch, or is also fit for existing ones like v1.6, v1.5? when true, please copy to them
6 participants
Adding a note in the beginning of the Remove disks section to mention that in case the disk to be removed hosts the last replica, deletion of thedisk will be rejected
Problem:
In 1.7 we no longer allow deletion of disks containing last healthy replicas and it can be confusing for the user.
Solution:
Add a note in the beginning of the
Remove diskssection to elaborate why the rejection might happen.Related Issue(s):
harvester/harvester#3344 (comment)
Test plan:
N/A
Additional documentation or context
N/A