Backport #11237: Fix two issues when starting the repl #11251
Merged
+511
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue 1: In 3.14 there was a poor error when starting a repl in a project context without any targets. In 3.16, this error regressed, so cabal just exited cleanly. Issue 2: The repl was broken when started from a global context. Issue 1 is fixed by checking to see if there are any user targets, and issuing a proper error if there are none. Issue 2 is fixed by specifying the correct fake target which is constructed when starting the repl in the global context. Both are reported in #11107 and fixed in this patch. Co-authored-by: Matthew Pickering <[email protected]> (cherry picked from commit 5e26932)
6 tasks
ulysses4ever
approved these changes
Oct 9, 2025
Mikolaj
approved these changes
Dec 4, 2025
Contributor
Author
Merge Queue Status✅ The pull request has been merged This pull request spent 1 hour 48 minutes 51 seconds in the queue, including 1 hour 45 minutes 31 seconds running CI. Required conditions to merge
|
This was referenced Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 1: In 3.14 there was a poor error when starting a repl in a project context without any targets. In 3.16, this error regressed, so cabal just exited cleanly.
Issue 2: The repl was broken when started from a global context.
Issue 1 is fixed by checking to see if there are any user targets, and issuing a proper error if there are none.
Issue 2 is fixed by specifying the correct fake target which is constructed when starting the repl in the global context.
Both are reported in #11107 and fixed in this patch.
Template Α: This PR modifies behaviour or interface
Include the following checklist in your PR:
significance: significantin the changelog file.This is an automatic backport of pull request #11237 done by [Mergify](https://mergify.com).