Fix #4935 and #4871#4937
Merged
Merged
Conversation
fendor
requested changes
May 20, 2026
Collaborator
fendor
left a comment
fendor
left a comment
There was a problem hiding this comment.
This looks good to me, thank you!
Could we have a regression test for this new behaviour?
Aster89
force-pushed
the
fix-issue-4935
branch
2 times, most recently
from
719f69c to
d32e3ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main reason for this PR is to fix #4935 by having
hls-class-plugindetect the indentation of already implemented methods (if any, otherwise the default of 2 is used as before) in aninstanceand use that for indenting the missing methods to be inserted.Additionally, I've included some other commits where I've removed some redundant
()s, changed some non-ASCII space to ASCII space, and one commit moving a misplaced haddock commet where it belongs, thus fixing #4871.