change lib-target in haskell-cabal-enum-targets to support multiple library components.#1800
Open
noinia wants to merge 3 commits intohaskell:masterfrom
Open
change lib-target in haskell-cabal-enum-targets to support multiple library components.#1800noinia wants to merge 3 commits intohaskell:masterfrom
noinia wants to merge 3 commits intohaskell:masterfrom
Conversation
purcell
reviewed
Mar 21, 2023
Member
|
Tests now fail with what looks like a legitimate mismatch — worth taking a look and/or adding new tests to reflect the correct behaviour. |
Member
|
Closing and re-opening to re-trigger CI and get a fresh picture of how this looks. |
Member
Is this correct? Should the expected list of targets now be changed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1796.