Replace highlight.js with static highlighting using Pandoc #437
Replace highlight.js with static highlighting using Pandoc #437TauOmicronMu wants to merge 3 commits intomainfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
isomorpheme
force-pushed
the
static-highlighting
branch
from
5cde36a to
09c539b
Compare
Co-authored-by: tauomicronmu <tauomicronmurs@gmail.com>
isomorpheme
force-pushed
the
static-highlighting
branch
from
09c539b to
3eab4ff
Compare
david-christiansen
left a comment
david-christiansen
left a comment
There was a problem hiding this comment.
For Haskell, this looks great to me.
But for other languages, it looks like Haskell highlighting is being used. Here's some YAML:
Shouldn't it branch on the code block language, or alternatively on the filename?
thanks!
message-index/site.hs
Outdated
| other -> other, | ||
| field "before" (maybe (pure "<not present>") (fmap itemBody . load . itemIdentifier) . view _2 . itemBody), | ||
| field "after" (maybe (pure "<not present>") (fmap itemBody . load . itemIdentifier) . view _3 . itemBody) | ||
| -- TODO: pick the right language |
There was a problem hiding this comment.
Is this a stale TODO?
There was a problem hiding this comment.
I'll have a look at it now!
| case takeExtension name of | ||
| ".hs" -> "haskell" | ||
| _ -> "" | ||
| pure $ T.unpack $ highlight language $ T.pack $ exampleText |
Check notice
Code scanning / HLint
Redundant $
Co-authored-by: Daan Rijks <daanrijks@pm.me>
TauOmicronMu
force-pushed
the
static-highlighting
branch
from
56037cd to
d2cf854
Compare
|
Is this still a draft? What do you see as the remaining tasks for un-drafting it? |
|
@isomorpheme - completely forgot about this -> do you remember what we had left to do (if anything)? |
|
@TauOmicronMu Hmm, I don't remember anything besides what's already mentioned in this PR (mainly picking the right language to highlight with). And this needs a rebase to fix merge conflicts of course. |
3 participants
🥳 🎉