This repository was archived by the owner on Jun 12, 2024. It is now read-only.
Change maintenance dialog field order #909
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the currency of norwegian krones back into the file. There was an earlier commit where this seems to have dropped of the table.
add: norwegian kroner
When using the maintenance dialog, the order title/scheduled/completed/costs/notes seems to be more sensible than title/completed/scheduled/notes/costs. Though notes/costs vs. costs/notes certainly can be argued about, in most of my cases this order would be more useful than the other way around.
Contributor
Author
|
Not sure why these checks fail. It looks to me like something is wrong with the CICD infrastructure. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
This PR changes the order of the fields in the maintenance dialog. The original order was
title/completed/scheduled/notes/costs.This changed to
title/scheduled/completed/costs/notes.When using the maintenance dialog the scheduled information was always earlier available than when the maintenance was completed. Therefore that field coming right after the title seems to be more sensible.
Something similar was/is true for the order of costs and notes. In my use cases I have more often a value for
costthan actually fornotes, which is why it seems more meaningful to have the field coming beforenotes. Alsonotesis the bigger field, which layout wise makes it slightly more sensible to put to the end. That wayCostsdoes not get completely out of focus.Which issue(s) this PR fixes:
None
Testing
Release Notes