fix(tracker): make Project.defaultIssueStatus optional#10598
Merged
ArtyomSavchenko merged 1 commit intohcengineering:developfrom Mar 10, 2026
Merged
Conversation
|
Connected to Huly®: UBERF-15804 |
cceac35 to
2904d0d
Compare
defaultIssueStatus is not reliably populated for all projects.Make the field optional in the type definition and guard the migration to handle undefined values. Signed-off-by: Igor Loskutov <igor.loskutoff@gmail.com>
2904d0d to
22af175
Compare
Contributor
Author
|
updated to passing CI |
ArtyomSavchenko
approved these changes
Mar 10, 2026
Member
|
Hi @dearlordylord |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #10597
The field is undefined at runtime for projects created without an explicit default status (e.g. workspace templates, CreateProject UI with no selection). The platform's own StatusEditor already handles this by falling back to statuses[0]. Making the type honest about the runtime reality surfaces latent bugs at compile time.
Call sites that may need updating:
SubIssues.svelte:51,79DraftIssueChildEditor.svelte:72,87migration.ts:203CreateVacancy.svelte:188side effects
to keep it compilable, had to change
migration.ts
This migration remaps old status refs to new status refs. If defaultIssueStatus is undefined, there is no ref to remap, the guard skips a no-op. The DocUpdateMessage activity migration still runs unconditionally for every project, so historical audit records are still migrated even for projects with no current defaultIssueStatus.
Tested on
Huly v0.7.353 (self-hosted), REST API via
@hcengineering/api-client.