test: update analytics tests to use the credential manager#3688
Merged
erika-wallace merged 2 commits intofeat/credential-mgr-integrationfrom May 4, 2026
Merged
test: update analytics tests to use the credential manager#3688erika-wallace merged 2 commits intofeat/credential-mgr-integrationfrom
erika-wallace merged 2 commits intofeat/credential-mgr-integrationfrom
Conversation
4fde394
into
feat/credential-mgr-integration
17 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR restores and updates the analytics unit tests that were commented out during the v11 migration to use the credential manager.
PR #3685 already updated
BackboardHerokulyticsClientto useAPIClientfrom@heroku-cli/commandinstead of reading credentials directly from netrc — these tests have been updated to match.Changes Made
stubCredentialManagerfrom the test helpersnetrcToken,netrcLogin,user,usingHerokuAPIKey)analytics.unit.test.ts→backboard-herokulytics-client.unit.test.tsand moved totest/unit/analytics-telemetry/for consistencyType of Change
Breaking Changes (major semver update)
!after your change type to denote a change that breaks current behaviorFeature Additions (minor semver update)
Patch Updates (patch semver update)
Testing
Notes:
Steps:
Screenshots (if applicable)
Related Issues
GUS work item: W-20867247