Skip to content

test(server): improve public net config test coverage #1271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

test(server): improve public net config test coverage #1271

wants to merge 10 commits into from

Conversation

@jooola
Copy link
Member

@jooola jooola commented Nov 20, 2025

No description provided.

jooola and others added 10 commits November 20, 2025 10:35
@jooola @apricote
test(server): improve coverage
e87b193 
Co-authored-by: Julian Tölle <[email protected]>
@jooola
test(server): tests toggling the server rescue
3e7e5b5 
Co-authored-by: Julian Tölle <[email protected]>

# Conflicts:
#	internal/server/resource_test.go
#	internal/server/testing.go
@jooola @apricote
test: add client logs in testsupport.CreateClient
72e763d 
Co-authored-by: Julian Tölle <[email protected]>
@jooola @apricote
test(server): test deletion with shutdown_before_deletion
f552ea2 
Co-authored-by: Julian Tölle <[email protected]>
@jooola @apricote
test(server): test server update in both directions
b89f8ff 
Co-authored-by: Julian Tölle <[email protected]>
@jooola
test: ensure iso is attached with update
95342e8
@jooola
chore: server network was already migrated
932a9a0
@jooola
style: move code around
51ec149
@jooola
test(server): ensure resource action
b840085
@jooola @apricote
test(server): improve public net config test coverage
9a8aa9c 
Co-authored-by: Julian Tölle <[email protected]>
@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

❌ Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 36.29%. Comparing base (b840085) to head (9a8aa9c).

Files with missing lines Patch % Lines
internal/server/resource.go 0.00% 21 Missing ⚠️
Additional details and impacted files 
@@                     Coverage Diff                      @@
##           plugin-framework-server    #1271       +/-   ##
============================================================
- Coverage                    71.62%   36.29%   -35.33%     
============================================================
  Files                           87       87               
  Lines                         9962     9969        +7     
============================================================
- Hits                          7135     3618     -3517     
- Misses                        1974     6304     +4330     
+ Partials                       853       47      -806
Flag Coverage Δ
e2e ?
unit 36.29% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Base automatically changed from plugin-framework-server to main November 20, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jooola