feat: Handle EIP-7702 code delegation #21964
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasz-hashgraph
requested review from
a team and
tinker-michaelj
as code owners
lukasz-hashgraph
changed the title
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
lukasz-hashgraph
force-pushed
the
feature/pectra-execution
branch
from
2f09564 to
4447a3f
Compare
lukasz-hashgraph
force-pushed
the
feature/pectra-execution
branch
from
7e6445e to
4b98cae
Compare
lukasz-hashgraph
changed the title
lukasz-hashgraph
force-pushed
the
feature/pectra-execution
branch
3 times, most recently
from
e07274e to
efde495
Compare
lukasz-hashgraph
force-pushed
the
feature/pectra-execution
branch
from
efde495 to
d037997
Compare
Signed-off-by: Lukasz Gasior <[email protected]>
Signed-off-by: Lukasz Gasior <[email protected]>
lukasz-hashgraph
force-pushed
the
feature/pectra-execution
branch
from
6578b57 to
42bfaa5
Compare
lukelee-sl
reviewed
Dec 9, 2025
hedera-node/hedera-smart-contract-service-impl/build.gradle.kts
Outdated
Show resolved
Hide resolved
lukelee-sl
reviewed
Dec 10, 2025
...va/com/hedera/node/app/service/contract/impl/exec/processors/CustomMessageCallProcessor.java
Show resolved
Hide resolved
lukelee-sl
reviewed
Dec 10, 2025
| doExecuteSystemContract(context, systemContracts.get(context.executableCodeAddress)); | ||
| } | ||
| } else { | ||
| // For any other accounts: code delegation to System Contracts is a no-op - so just succeed. |
Contributor
There was a problem hiding this comment.
Would it make sense to specify in the comment that this condition is only for Hedera accounts? To me this implies that if we have another entity type that can have a facade contract (like HCS), we will fall into this else clause but it seems likely that the new entity will be treated like token/schedule entities
lukelee-sl
reviewed
Dec 10, 2025
| private boolean isTokenCreation(MessageFrame frame) { | ||
| if (frame.getInputData().isEmpty()) { | ||
| return false; | ||
| if (isSystemContractCall(context)) { |
Contributor
There was a problem hiding this comment.
Overall, I really like this refactor. It makes things much cleaner.
lukelee-sl
reviewed
Dec 10, 2025
| * A set of call data prefixes (i.e. function selectors in the realm of Solidity) | ||
| * that are eligible for proxy redirection to the Hedera Account Service system contract. | ||
| */ | ||
| private static final Set<Integer> ACCOUNT_PROXY_ELIGIBLE_CALL_DATA_PREFIXES = Set.of( |
Contributor
There was a problem hiding this comment.
This seems a little out of place to me to be here. If we ever add a new function to HAS, I guess we will have to remember to maintain this list.
Contributor
Author
There was a problem hiding this comment.
Yeah, I couldn't find the right place for it. Any suggestions?
Contributor
There was a problem hiding this comment.
Maybe HasCallAttempt - not a strong preference as it is not used there really but logically it might fit there.
lukelee-sl
reviewed
Dec 10, 2025
...va/com/hedera/node/app/service/contract/impl/exec/processors/CustomMessageCallProcessor.java
Show resolved
Hide resolved
lukelee-sl
reviewed
Dec 10, 2025
.../java/com/hedera/node/app/service/contract/impl/exec/systemcontracts/has/HasCallFactory.java
Outdated
Show resolved
Hide resolved
lukelee-sl
reviewed
Dec 10, 2025
...e-impl/src/main/java/com/hedera/node/app/service/contract/impl/state/ScheduleEvmAccount.java
Outdated
Show resolved
Hide resolved
lukelee-sl
reviewed
Dec 10, 2025
...e-impl/src/main/java/com/hedera/node/app/service/contract/impl/state/hooks/ProxyEvmHook.java
Show resolved
Hide resolved
lukelee-sl
reviewed
Dec 10, 2025
...ervice-impl/src/main/java/com/hedera/node/app/service/contract/impl/state/EvmFrameState.java
Show resolved
Hide resolved
lukelee-sl
reviewed
Dec 10, 2025
.../src/main/java/com/hedera/node/app/service/contract/impl/state/DispatchingEvmFrameState.java
Outdated
Show resolved
Hide resolved
lukelee-sl
approved these changes
Dec 10, 2025
Contributor
lukelee-sl
left a comment
lukelee-sl
left a comment
There was a problem hiding this comment.
Generally looks really good. Up to you if you want to address any of my comments.
Signed-off-by: Lukasz Gasior <[email protected]>
stoyanov-st
approved these changes
Dec 10, 2025
Contributor
stoyanov-st
left a comment
stoyanov-st
left a comment
There was a problem hiding this comment.
Adding to most of Luke's comments
LG so far, really nice cleanup, thanks @lukasz-hashgraph 🙌
...e-impl/src/main/java/com/hedera/node/app/service/contract/impl/state/ScheduleEvmAccount.java
Show resolved
Hide resolved
Signed-off-by: Lukasz Gasior <[email protected]>
stoyanov-st
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added EIP-7702 code delegation handling when processing calls.
Includes the proxy/facade refactoring described in HIP-1340.
Related issue: #21198