Skip to content

Conversation

@petreze
Copy link
Contributor

@petreze petreze commented Dec 1, 2025

Description:
This PR adds a support for governance transactions in an AtomicBatch. Meaning that inner transactions in a batch can be higher than 6KBs but limited to 130KBs, if they are payed by a governance account. The governance account must also pay for the AtomicBatch in order for a successful execution. The AtomicBatch itself is also restricted to the upper limit of 130KBs

Related issue(s):

Fixes #22407

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Petar Tonev <[email protected]>
@petreze petreze self-assigned this Dec 1, 2025
@petreze petreze requested review from a team as code owners December 1, 2025 16:02
@lfdt-bot
Copy link

lfdt-bot commented Dec 1, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@petreze petreze changed the title chore: extend tests for HIP-1300 feat: extend tests for HIP-1300 and support them in an AtomicBatch Dec 1, 2025
@codacy-production
Copy link

codacy-production bot commented Dec 1, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.01% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (5d86477) 105402 78878 74.84%
Head commit (bcf8b5c) 105408 (+6) 78889 (+11) 74.84% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#22367) 8 8 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...-app/src/main/java/com/hedera/node/app/Hedera.java 83.33% 0 Missing and 1 partial ⚠️

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #22367   +/-   ##
=========================================
  Coverage     70.97%   70.97%           
+ Complexity    24710    24709    -1     
=========================================
  Files          2705     2705           
  Lines        105499   105505    +6     
  Branches      11108    11109    +1     
=========================================
+ Hits          74877    74887   +10     
+ Misses        26575    26570    -5     
- Partials       4047     4048    +1     
Files with missing lines Coverage Δ Complexity Δ
...a/node/app/config/BootstrapConfigProviderImpl.java 94.11% <100.00%> (+0.36%) 3.00 <0.00> (ø)
...-app/src/main/java/com/hedera/node/app/Hedera.java 52.83% <83.33%> (+0.19%) 51.00 <0.00> (ø)

... and 3 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@derektriley derektriley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@AlexKehayov AlexKehayov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@stoyanov-st stoyanov-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from smart-contract perspective

@petreze petreze merged commit 6c5b1a0 into main Dec 2, 2025
193 of 196 checks passed
@petreze petreze deleted the pt/hip1300-more-tests branch December 2, 2025 16:21
petreze added a commit that referenced this pull request Dec 2, 2025
petreze added a commit that referenced this pull request Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for governance transactions in an AtomicBatch

6 participants