-
Notifications
You must be signed in to change notification settings - Fork 185
feat: extend tests for HIP-1300 and support them in an AtomicBatch
#22367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Petar Tonev <[email protected]>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Signed-off-by: Petar Tonev <[email protected]>
AtomicBatch
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #22367 +/- ##
=========================================
Coverage 70.97% 70.97%
+ Complexity 24710 24709 -1
=========================================
Files 2705 2705
Lines 105499 105505 +6
Branches 11108 11109 +1
=========================================
+ Hits 74877 74887 +10
+ Misses 26575 26570 -5
- Partials 4047 4048 +1
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
derektriley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
AlexKehayov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
stoyanov-st
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from smart-contract perspective
…22367) Signed-off-by: Petar Tonev <[email protected]> (cherry picked from commit 6c5b1a0)
…22367) Signed-off-by: Petar Tonev <[email protected]>
Description:
This PR adds a support for governance transactions in an
AtomicBatch. Meaning that inner transactions in a batch can be higher than 6KBs but limited to 130KBs, if they are payed by a governance account. The governance account must also pay for theAtomicBatchin order for a successful execution. TheAtomicBatchitself is also restricted to the upper limit of 130KBsRelated issue(s):
Fixes #22407
Notes for reviewer:
Checklist