-
Notifications
You must be signed in to change notification settings - Fork 185
chore: Integrate PBJ lib prereq to tss.wrapsEnabled=true
#22478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
…Throttles() Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Signed-off-by: Michael Tinker <[email protected]>
anthony-swirldslabs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, but there's one major comment. Thanks!
...a-node/hapi-utils/src/main/java/com/hedera/node/app/hapi/utils/blocks/BlockStreamAccess.java
Outdated
Show resolved
Hide resolved
hedera-node/hapi-utils/src/main/java/com/hedera/node/app/hapi/utils/CommonPbjConverters.java
Outdated
Show resolved
Hide resolved
hedera-node/hedera-app/src/main/java/com/hedera/node/app/history/impl/WrapsHistoryProver.java
Outdated
Show resolved
Hide resolved
hedera-node/hedera-app/src/main/java/com/hedera/node/app/workflows/TransactionChecker.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/hedera/services/bdd/junit/support/translators/inputs/TransactionParts.java
Outdated
Show resolved
Hide resolved
platform-sdk/swirlds-virtualmap/src/main/java/com/swirlds/virtualmap/VirtualMap.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #22478 +/- ##
============================================
- Coverage 74.67% 74.66% -0.01%
- Complexity 23559 23583 +24
============================================
Files 2520 2521 +1
Lines 95687 95793 +106
Branches 10173 10186 +13
============================================
+ Hits 71451 71523 +72
- Misses 20445 20474 +29
- Partials 3791 3796 +5 ... and 14 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Neeharika-Sompalli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @tinker-michaelj 🙌
anthony-swirldslabs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Description:
0.12.10and passes appropriatemaxSizeoverrides to node txCodec.parse()calls.