Skip to content

Conversation

@tinker-michaelj
Copy link
Contributor

@tinker-michaelj tinker-michaelj commented Dec 8, 2025

Description:

  • Closes Integrate PBJ 0.12.10 for TSS E2E testing #22375
  • Updates to PBJ 0.12.10 and passes appropriate maxSize overrides to node tx Codec.parse() calls.
  • Adds "jitter" before a node submits its proof vote on a WRAPS proof so it has a chance to prefer submitting a "congruent" vote affirming another honest node's proof (and hence avoiding another large block stream item).

Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
@lfdt-bot
Copy link

lfdt-bot commented Dec 8, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Signed-off-by: Michael Tinker <[email protected]>
Copy link
Contributor

@anthony-swirldslabs anthony-swirldslabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, but there's one major comment. Thanks!

lpetrovic05
lpetrovic05 previously approved these changes Dec 9, 2025
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
@codacy-production
Copy link

codacy-production bot commented Dec 9, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.01% (target: -1.00%) 89.58%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (976bbea) 95590 75194 78.66%
Head commit (0186021) 95696 (+106) 75271 (+77) 78.66% (-0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#22478) 240 215 89.58%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

❌ Patch coverage is 85.83333% with 34 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...dera/node/app/history/impl/WrapsHistoryProver.java 82.27% 19 Missing and 9 partials ⚠️
...dera/node/app/history/impl/HistorySubmissions.java 0.00% 4 Missing ⚠️
.../node/app/hapi/utils/blocks/BlockStreamAccess.java 50.00% 2 Missing ⚠️

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #22478      +/-   ##
============================================
- Coverage     74.67%   74.66%   -0.01%     
- Complexity    23559    23583      +24     
============================================
  Files          2520     2521       +1     
  Lines         95687    95793     +106     
  Branches      10173    10186      +13     
============================================
+ Hits          71451    71523      +72     
- Misses        20445    20474      +29     
- Partials       3791     3796       +5     
Files with missing lines Coverage Δ Complexity Δ
...edera/node/app/hapi/utils/CommonPbjConverters.java 71.96% <100.00%> (+0.13%) 45.00 <0.00> (ø)
...va/com/hedera/node/app/history/HistoryLibrary.java 100.00% <100.00%> (ø) 3.00 <0.00> (ø)
...ry/handlers/HistoryProofKeyPublicationHandler.java 96.77% <100.00%> (-0.11%) 10.00 <0.00> (ø)
...dera/node/app/history/impl/HistoryLibraryImpl.java 61.53% <100.00%> (ø) 11.00 <1.00> (+1.00)
...om/hedera/node/app/history/impl/HistoryProver.java 100.00% <ø> (+20.00%) 3.00 <0.00> (ø)
...dera/node/app/history/impl/HistoryServiceImpl.java 84.44% <100.00%> (ø) 14.00 <0.00> (ø)
...ra/node/app/history/impl/InertProofController.java 83.33% <ø> (+4.38%) 7.00 <0.00> (ø)
...era/node/app/history/impl/ProofControllerImpl.java 79.25% <100.00%> (ø) 36.00 <0.00> (ø)
...hedera/node/app/history/impl/ProofControllers.java 94.59% <100.00%> (+0.47%) 13.00 <2.00> (+1.00)
...ode/app/history/impl/ReadableHistoryStoreImpl.java 71.15% <ø> (-0.55%) 16.00 <0.00> (ø)
... and 9 more

... and 14 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
@tinker-michaelj tinker-michaelj added this to the v0.70 milestone Dec 10, 2025
@tinker-michaelj tinker-michaelj self-assigned this Dec 10, 2025
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Copy link
Contributor

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @tinker-michaelj 🙌

Copy link
Contributor

@anthony-swirldslabs anthony-swirldslabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@tinker-michaelj tinker-michaelj merged commit 3a03c1f into main Dec 10, 2025
79 of 82 checks passed
@tinker-michaelj tinker-michaelj deleted the enable-ci-wraps branch December 10, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integrate PBJ 0.12.10 for TSS E2E testing

7 participants