-
Notifications
You must be signed in to change notification settings - Fork 39
Instrumentation (without Call) #355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ChingLongTin
wants to merge
222
commits into
hkust-taco:hkmc2
Choose a base branch
from
ChingLongTin:instrument
base: hkmc2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+926
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `staged` keyword
add Block.mls
merge upstream hkmc2
…ation during diff testing
…ring Add Block.mls into DiffMaker and prepare the function for lowering Use older Import syntax for now
LPTK
reviewed
Nov 27, 2025
this implements the rest function that narrows the shape as more match statements are processed
as discussed in the meeting, we will perform the within mlscript to reduce complexity
Author
|
From the meeting, the logic for shape will now be implemented in mlsript, so I am reducing the scope of Instrumentation.scala to just handle conversion from Block into Block IR. I will mark this pr as ready when that is done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call implementation will be after the algorithms for instrumenting functions are completed.
allocating
optionNmeThis changed some diff tests (
OpenWildcard.mls,Imports.mls,ImportMLs.mls) that imported Option themselves.If I allocate
optionNmeafter checking ifstageCodeis enabled, it fails to link to the file.Is there some way to avoid changing the diff tests, or is this fine?
implementing I-Inst
The current shape for Class
C(n:s)includes the field names (n), but the field names are not available inInstantiation.The field names are used in
sel. If the class is staged using I-Cls, then we can use the stagedClsLikeDefnto retrieve the symbol names, but when do we do when it isn't staged?