type annotation for raw texture to accept numpy#2064
Open
wlwatkins wants to merge 1 commit intohoffstadt:masterfrom
Open
type annotation for raw texture to accept numpy#2064wlwatkins wants to merge 1 commit intohoffstadt:masterfrom
wlwatkins wants to merge 1 commit intohoffstadt:masterfrom
Conversation
As the doc says https://dearpygui.readthedocs.io/en/latest/documentation/textures.html#raw-textures , `add_raw_texture` should accept `numpy.ndarray`, but is it not in the default type hint, hence my ide is not happy. would this addition be agreable with you?
Author
|
hum... just realised numpy is not imported, and something tells me this is a big deal. i'm not sure if there's an alternative but to import it, at least using the type_check module |
|
+1 but this should be: import numpy as np
import numpy.typing as npt
def add_raw_texture(
...
default_value: Union[List[float], Tuple[float, ...], npt.NDArray[np.float32]]
) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: Pull Request
about: Create a pull request to help us improve
title: type annotation for raw texture to accept numpy
assignees: ''
Description:
As the doc says https://dearpygui.readthedocs.io/en/latest/documentation/textures.html#raw-textures ,
add_raw_textureshould acceptnumpy.ndarray, but is it not in the default type hint, hence my ide is not happy. would this addition be agreable with you?Concerning Areas:
Maybe there is other places, but this worked for me