Add benchmarks #75
Open
Add benchmarks #75
+296
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasperisager
requested changes
Nov 13, 2025
package.json
Outdated
Comment on lines
13
to
15
| "bin": { | ||
| "rocksdb-bench": "bench/cli.js" | ||
| }, |
Contributor
There was a problem hiding this comment.
Suggested change
| "bin": { | |
| "rocksdb-bench": "bench/cli.js" | |
| }, |
This will cause the published package to try to install bench/cli.js, which it can't and shouldn't. The CLI must be strictly internal.
Contributor
|
The general approach is good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The harness file was adapted from https://github.com/holepunchto/bare/blob/main/bench/harness.js.
The idea is to evolve the PR to use
paparamto create a CLI interface with options to customize the values used by RocksDB options and also options to customize some hard-coded values from the hardness file.