Skip to content

Conversation

@jeremiahpslewis
Copy link

@jeremiahpslewis jeremiahpslewis commented Nov 6, 2025

Proposed change

This PR improves the ThermoPro BLE integration by fixing the issue where entities appeared unavailable after a Home Assistant restart.

See here for the PR which introduced the functionality that fixes the issue: https://github.com/home-assistant/core/pull/97462/files#diff-b693e3cfb116c5e5b9bf844c797c6f2ca631a5a9e76dc1d9f320a2a9361bed0cR315

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Nov 6, 2025

Hey there @bdraco, @h3ss, mind taking a look at this pull request as it has been labeled with an integration (thermopro) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of thermopro can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign thermopro Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@jeremiahpslewis jeremiahpslewis marked this pull request as ready for review November 6, 2025 12:15
Copilot AI review requested due to automatic review settings November 6, 2025 12:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for entity restoration on restart for the ThermoPro Bluetooth integration by passing SensorEntityDescription as a parameter to the async_register_processor method. This enables the passive Bluetooth data processor to properly restore entity states and descriptions when Home Assistant restarts.

  • Adds SensorEntityDescription parameter to coordinator.async_register_processor() call in sensor setup
  • Adds comprehensive test coverage to verify entity restoration behavior on restart

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
homeassistant/components/thermopro/sensor.py Adds SensorEntityDescription parameter to processor registration to enable entity restoration
tests/components/thermopro/test_sensor.py Adds test to verify entities are properly restored on restart via SensorEntityDescription parameter

@jeremiahpslewis
Copy link
Author

@bdraco took a couple of tries, but this seems to do the trick, running well on my local instance.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh hi there @jeremiahpslewis 👋

Thanks for opening a pull request. However, our automated testing pipelines didn't pass. Can you take a look and make sure that CI passes.

Thanks! 👍

../Frenck

@home-assistant
Copy link

home-assistant bot commented Nov 8, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft November 8, 2025 14:18
@jeremiahpslewis jeremiahpslewis marked this pull request as ready for review November 8, 2025 22:54
@home-assistant home-assistant bot requested a review from frenck November 8, 2025 22:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@jeremiahpslewis
Copy link
Author

@frenck I believe I've covered your requested change, please let me know if there is anything else missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants