-
-
Notifications
You must be signed in to change notification settings - Fork 35.9k
Fix Thermopro 'Device not available' on Restart #155929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Fix Thermopro 'Device not available' on Restart #155929
Conversation
|
Hey there @bdraco, @h3ss, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for entity restoration on restart for the ThermoPro Bluetooth integration by passing SensorEntityDescription as a parameter to the async_register_processor method. This enables the passive Bluetooth data processor to properly restore entity states and descriptions when Home Assistant restarts.
- Adds
SensorEntityDescriptionparameter tocoordinator.async_register_processor()call in sensor setup - Adds comprehensive test coverage to verify entity restoration behavior on restart
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| homeassistant/components/thermopro/sensor.py | Adds SensorEntityDescription parameter to processor registration to enable entity restoration |
| tests/components/thermopro/test_sensor.py | Adds test to verify entities are properly restored on restart via SensorEntityDescription parameter |
|
@bdraco took a couple of tries, but this seems to do the trick, running well on my local instance. |
frenck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh hi there @jeremiahpslewis 👋
Thanks for opening a pull request. However, our automated testing pipelines didn't pass. Can you take a look and make sure that CI passes.
Thanks! 👍
../Frenck
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
|
@frenck I believe I've covered your requested change, please let me know if there is anything else missing |
Proposed change
This PR improves the ThermoPro BLE integration by fixing the issue where entities appeared unavailable after a Home Assistant restart.
See here for the PR which introduced the functionality that fixes the issue: https://github.com/home-assistant/core/pull/97462/files#diff-b693e3cfb116c5e5b9bf844c797c6f2ca631a5a9e76dc1d9f320a2a9361bed0cR315
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: