Skip to content

Conversation

@Diegorro98
Copy link
Contributor

@Diegorro98 Diegorro98 commented Nov 6, 2025

Proposed change

Add fan entity to control the fan of an air conditioner from the Home Connect integration
It allows to:

  • Set the fan speed
  • Set the fan mode

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Nov 6, 2025

Hey there @DavidMStraub, @MartinHjelmare, mind taking a look at this pull request as it has been labeled with an integration (home_connect) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of home_connect can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign home_connect Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds fan entity support for Home Connect air conditioner devices, enabling control of fan speed mode (automatic/manual) and fan speed percentage through Home Assistant's fan platform.

  • Implements a new HomeConnectAirConditioningFanEntity with support for preset modes and speed percentage control
  • Adds comprehensive test coverage for fan entities including device pairing/unpairing, connection states, and feature detection
  • Integrates air conditioner programs and fixtures to support testing

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
homeassistant/components/home_connect/fan.py New fan platform implementation with dynamic entity creation based on available options, supporting both preset modes and speed percentage control
homeassistant/components/home_connect/init.py Adds Platform.FAN to the list of supported platforms
homeassistant/components/home_connect/const.py Adds FAN_SPEED_MODE_OPTIONS mapping and includes "AirConditioner" in APPLIANCES_WITH_PROGRAMS
homeassistant/components/home_connect/strings.json Adds translation keys for fan preset modes (auto/manual)
tests/components/home_connect/test_fan.py Comprehensive test suite covering device lifecycle, availability, speed/preset mode functionality, error handling, and dynamic entity creation
tests/components/home_connect/conftest.py Refactors test fixtures to extract _get_set_program_option_side_effect function for better code reuse
tests/components/home_connect/fixtures/appliances.json Adds air conditioner test appliance fixture
tests/components/home_connect/fixtures/programs.json Adds air conditioner programs fixture data
tests/components/home_connect/snapshots/test_diagnostics.ambr Updates diagnostics snapshot to include air conditioner test data

Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linters are failing

@home-assistant
Copy link

home-assistant bot commented Nov 7, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft November 7, 2025 09:27
@Diegorro98 Diegorro98 marked this pull request as ready for review November 7, 2025 09:50
@home-assistant home-assistant bot requested a review from emontnemery November 7, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants