-
-
Notifications
You must be signed in to change notification settings - Fork 35.9k
Add fan entity for air conditioner to Home Connect #155983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
Hey there @DavidMStraub, @MartinHjelmare, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds fan entity support for Home Connect air conditioner devices, enabling control of fan speed mode (automatic/manual) and fan speed percentage through Home Assistant's fan platform.
- Implements a new
HomeConnectAirConditioningFanEntitywith support for preset modes and speed percentage control - Adds comprehensive test coverage for fan entities including device pairing/unpairing, connection states, and feature detection
- Integrates air conditioner programs and fixtures to support testing
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| homeassistant/components/home_connect/fan.py | New fan platform implementation with dynamic entity creation based on available options, supporting both preset modes and speed percentage control |
| homeassistant/components/home_connect/init.py | Adds Platform.FAN to the list of supported platforms |
| homeassistant/components/home_connect/const.py | Adds FAN_SPEED_MODE_OPTIONS mapping and includes "AirConditioner" in APPLIANCES_WITH_PROGRAMS |
| homeassistant/components/home_connect/strings.json | Adds translation keys for fan preset modes (auto/manual) |
| tests/components/home_connect/test_fan.py | Comprehensive test suite covering device lifecycle, availability, speed/preset mode functionality, error handling, and dynamic entity creation |
| tests/components/home_connect/conftest.py | Refactors test fixtures to extract _get_set_program_option_side_effect function for better code reuse |
| tests/components/home_connect/fixtures/appliances.json | Adds air conditioner test appliance fixture |
| tests/components/home_connect/fixtures/programs.json | Adds air conditioner programs fixture data |
| tests/components/home_connect/snapshots/test_diagnostics.ambr | Updates diagnostics snapshot to include air conditioner test data |
emontnemery
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linters are failing
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Proposed change
Add fan entity to control the fan of an air conditioner from the Home Connect integration
It allows to:
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: