Skip to content

Conversation

@laurynasgadl
Copy link
Member

@laurynasgadl laurynasgadl commented Jan 15, 2026

Summary by CodeRabbit

  • New Features

    • Added logout reason parameter for enhanced user feedback upon logout
  • Bug Fixes

    • Improved logout flow with enhanced proxy logout handling and clearer post-logout navigation sequencing

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 15, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Two files are modified: Languages.vue receives a syntactic change removing quotes from object keys with no functional impact, while auth.ts enhances the logout flow with proxy logout support and revised post-logout navigation routing logic.

Changes

Cohort / File(s) Summary
Syntax/Formatting Update
frontend/src/components/settings/Languages.vue
Object keys converted from string literals to unquoted identifiers in locales mapping; no functional change.
Enhanced Logout Flow
frontend/src/utils/auth.ts
Logout now attempts proxy logout when authMethod is "proxy" and logout URL exists; conditional navigation routes based on noAuth flag, logoutPage config, and optional logout reason parameter; auth state cleared after proxy request completes.

Sequence Diagrams

sequenceDiagram
    participant User
    participant App as Frontend App
    participant ProxyAuth as Proxy/Auth Server
    participant Store as Auth Store
    participant Router as Router

    User->>App: Initiate logout
    
    alt authMethod is "proxy" & logoutURL exists
        App->>ProxyAuth: POST to authLogoutURL
        alt Proxy request succeeds
            ProxyAuth-->>App: Success response
        else Proxy request fails
            App->>App: Log error
        end
    end
    
    App->>Store: Clear auth state
    App->>App: Clear JWT token
    
    alt noAuth is true
        App->>App: Reload page
    else logoutPage ≠ "/login"
        App->>Router: Redirect to logoutPage
    else
        alt logout reason provided
            App->>Router: Navigate to /login?logout-reason=<reason>
        else
            App->>Router: Navigate to /login
        end
    end
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

✨ Finishing touches
  • 📝 Generate docstrings


📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3c97c3c and 2fc7278.

📒 Files selected for processing (2)
  • frontend/src/components/settings/Languages.vue
  • frontend/src/utils/auth.ts

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@laurynasgadl laurynasgadl merged commit ecd32f7 into master Jan 15, 2026
3 of 4 checks passed
@laurynasgadl laurynasgadl deleted the fix/logout-action-order branch January 15, 2026 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant