[fix #762] Forward broadcast_refresh_to options #763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@seanpdoyle It occurs to me now, that also updating the Broadcastable model concern might be the other thing required to support hotwired/turbo#1208. I like what you said here:
Would you like me to do that here as well? |
seanpdoyle
reviewed
Nov 21, 2025
seanpdoyle
force-pushed
the
forward-broadcast-refresh-options
branch
from
c38130d to
0a4759a
Compare
…am_refresh_tag Update Broadcastable concern to support the StreamsChannel API Co-authored-by: Sean Doyle <[email protected]>
seanpdoyle
force-pushed
the
forward-broadcast-refresh-options
branch
from
0a4759a to
3768c48
Compare
Contributor
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previously ignored options of
broadcast_refresh_toare now forwarded toturbo_stream_refresh_tag.This PR resolves #762 and is in support of hotwired/turbo#1208.