Fixing two recognize-gesture deprecation messages#137
Open
lupestro wants to merge 4 commits intohtml-next:masterfrom
Open
Fixing two recognize-gesture deprecation messages#137lupestro wants to merge 4 commits intohtml-next:masterfrom
lupestro wants to merge 4 commits intohtml-next:masterfrom
Conversation
Fixed invocation of -gestures service during render. ember-modifiers use now requires minimum Ember 3.3.
Contributor
Author
|
The travis-ci failures in LTS 2.12, 2.16, 2.18 are expected with this change. We're effectively reducing the range of Ember versions with which this will work so that the modifier will work without deprecations in recent versions of Ember. It will definitely need a new major version to insulate users of Ember < 3.3 from the change. |
Contributor
|
@lupestro willRemove() {
this.manager.destroy();
this.manager = null;
}to willRemove() {
if (this.manager !== null) {
this.manager.destroy();
this.manager = null;
}
} |
Contributor
Author
|
Hi @pieter-v - I swung back around here, doing maintenance on a related project, and stumbled over your comment from back in March. I'll make the fix shortly. Sorry for the long delay. |
Contributor
|
@lupestro thanx |
galfert
added a commit
to 67P/hyperchannel
that referenced
this pull request
Dec 3, 2021
Fixes a deprecation warning when used with Ember 3.24. Taken from html-next/ember-gestures#137
galfert
added a commit
to 67P/hyperchannel
that referenced
this pull request
Dec 7, 2021
Fixes a deprecation warning when used with Ember 3.24. Taken from html-next/ember-gestures#137
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated
recognize-gesturemodifier to use latestember-modifier(fixes one deprecation)Fixed
recognize-gestureinvocation of-gesturesservice during render (fixes the other)Using ember-modifier requires a minimum of Ember 3.3 (rather than 3.1) for ember-destroyable-plugin, which it calls internally, to function. Not sure if that qualifies this fix to be a sem-ver major bump, but I suspect so.
I'll defer updating the changelog until I hear what the committers want to do.