Skip to content

Fix Network_Container::site_exists() querying wrong database table #1312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jbrejcha wants to merge 14 commits into
base: development
Choose a base branch
from
Open

Fix Network_Container::site_exists() querying wrong database table #1312

Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
542301f
Merge branch 'development'
jorostoyanov Nov 10, 2023
5692f66
Add bundles
jorostoyanov Nov 10, 2023
6859164
Add unminified bundles
jorostoyanov Nov 10, 2023
dd9d967
Merge branch 'development'
jorostoyanov Nov 13, 2023
ecf71b4
Add bundles
jorostoyanov Nov 13, 2023
bc26d30
Merge branch 'development'
htmlburger-git Nov 28, 2023
ca90629
Add bundles
htmlburger-git Nov 28, 2023
1b51f6e
Merge branch 'development'
atanas-vasilev-dev Jul 31, 2024
a590865
Add bundles.
atanas-vasilev-dev Jul 31, 2024
b18f8e2
Merge branch 'development'
atanas-vasilev-dev Jul 31, 2024
9cb536e
Merge branch 'development'
ikolarov Apr 17, 2025
6981efa
Merge branch 'development'
ikolarov May 7, 2025
f82e80e
Merge branch 'development'
ikolarov Jun 11, 2025
e2fc596
Fix Network_Container::site_exists() validating against wrong table
jbrejcha Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions core/Container/Network_Container.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,18 +43,17 @@ public function init() {
}

/**
* Check if a site exists by id
* Check if a network site exists by id
*
* @param integer $id
* @return boolean
*/
protected function site_exists( $id ) {
if ( ! function_exists( 'get_blog_status' ) ) {
return false;
}

$blog_domain = get_blog_status( $id, 'domain' );
return ! empty( $blog_domain );
global $wpdb;
$network = $wpdb->get_row( $wpdb->prepare(
"SELECT id FROM {$wpdb->site} WHERE id = %d", $id
) );
return ! empty( $network );
}

/**
Expand Down