Allow 'disabled' HTML attribute on field types#1313
Open
jbrejcha wants to merge 14 commits intohtmlburger:developmentfrom
Open
Allow 'disabled' HTML attribute on field types#1313jbrejcha wants to merge 14 commits intohtmlburger:developmentfrom
jbrejcha wants to merge 14 commits intohtmlburger:developmentfrom
Conversation
The allowed_attributes whitelist rejected 'disabled' with an error, even though it is a standard HTML form attribute. Add it to the base Field class and all subclasses that override the whitelist. Fixes htmlburger#1306
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
allowed_attributeswhitelist rejected the standard HTMLdisabledattribute with an error. This addsdisabledto the baseFieldclass and all subclasses that override the whitelist (Text_Field,Textarea_Field,Date_Field).Fixes #1306