Skip to content

Fix unauthenticated access to REST API endpoints #1315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jbrejcha wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Fix unauthenticated access to REST API endpoints #1315

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions core/REST_API/Router.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,11 +168,27 @@ public function get_vendor() {
}

/**
* Allow access to an endpoint
* Allow access to an endpoint.
*
* @return bool
* Requires the user to be logged in by default. Use the
* `carbon_fields_rest_api_allow_public_access` filter to allow
* unauthenticated access for intentionally public endpoints.
*
* @return bool|\WP_Error
*/
public function allow_access() {
if ( apply_filters( 'carbon_fields_rest_api_allow_public_access', false ) ) {
return true;
}

if ( ! is_user_logged_in() ) {
return new \WP_Error(
'rest_forbidden',
__( 'You must be logged in to access Carbon Fields data.', 'carbon-fields' ),
array( 'status' => rest_authorization_required_code() )
);
}

return true;
}

Expand Down