Open
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| mock_result.reward = 1.0 | ||
|
|
||
| with patch("hud.eval.task.Task.run", new_callable=AsyncMock, return_value=mock_result): | ||
| await chat.send("hello") |
There was a problem hiding this comment.
Test patches class method but instance is MagicMock
Medium Severity
The patch targets hud.eval.task.Task.run on the Task class, but dummy_task is a MagicMock, not a Task instance. When Chat.send() calls task.run(...), task is the MagicMock returned by model_copy, so task.run(...) invokes MagicMock's auto-generated run attribute — not the patched Task.run. This returns a non-awaitable MagicMock, causing await task.run(...) to raise TypeError. The patch has no effect on the actual code path being tested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Note
Medium Risk
Introduces a new
Task.run()execution path that wrapsrun_eval()and is now used byChat.send(), so any behavior differences could affect evaluation tracing/reward propagation. Also changes file/path handling for coding tools on Windows, which may have platform-specific edge cases.Overview
Adds
Task.run()as a one-liner helper to execute a single task (accepting a model string or agent instance), internally creating the eval context viarun_eval()and propagatingctx.rewardonto the returnedTrace.Refactors
Chat.send()and multiple docs/examples to usetask.run(...)/env(...).run(...)instead of manually creating an eval context and running the agent.Improves Windows compatibility in coding tools by giving a Windows-specific absolute-path error in
EditTool.validate_path()and falling back to direct file I/O inread_file_async/write_file_asyncwhen shell utilities/heredocs aren’t available.Written by Cursor Bugbot for commit e27a71d. This will update automatically on new commits. Configure here.