Fix: pass through custom_tasks and enable multilingual in eval command#1172
Open
dzautner wants to merge 1 commit intohuggingface:mainfrom
Open
Fix: pass through custom_tasks and enable multilingual in eval command#1172dzautner wants to merge 1 commit intohuggingface:mainfrom
dzautner wants to merge 1 commit intohuggingface:mainfrom
Conversation
The eval() function accepts --custom-tasks and multilingual task names as CLI parameters but hardcodes custom_tasks=None and load_multilingual=False when creating the Registry, silently ignoring both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eval()function inmain_inspect.pyaccepts--custom-tasksand multilingual task names as CLI parameters but hardcodescustom_tasks=Noneandload_multilingual=Falsewhen creating theRegistry, silently ignoring both.Test plan
maime25:da) are now discoverable vialighteval eval--custom-tasksis properly passed through to the Registry