Safe support to claim a hypercert#496
Draft
pheuberger wants to merge 3 commits intohypercerts-org:devfrom
Draft
Conversation
pheuberger
force-pushed
the
safe-support-claim-hypercert
branch
from
611e3ef to
1f3d2c3
Compare
|
@pheuberger is attempting to deploy a commit to the Hypercerts Foundation Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pheuberger
force-pushed
the
safe-support-claim-hypercert
branch
from
1f3d2c3 to
2b76864
Compare
Without this patch multisigs that have Hypercerts to be claimed have no straightforward way of claiming them. This patch introduces the same patterns as used for minting a Hypercert from a Safe.
When disconnected the button was showing "Switch chain". Now it shows "Claim" and only an outline. It's disabled as well until the user connects their wallet.
In the previous commit 5ca3a2c I missed adding support for batch claiming hypercerts. This patch adds another set of strategies for this case, nicely abstracting all these code paths into their own strategy.
pheuberger
force-pushed
the
safe-support-claim-hypercert
branch
from
2b76864 to
d9ed59d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First we need to ship the Hypercert SDK PR: hypercerts-org/hypercerts-sdk#39
Then we should ship hypercerts-org/hypercerts-api#281 and use it to test the preview build.
After that we can move this out of draft and ship it too.
Example transaction created using this code: https://app.safe.global/transactions/tx?safe=sep:0x6C622Ca31a755b4A543f1FE1dB26A666A468Fda8&id=multisig_0x6C622Ca31a755b4A543f1FE1dB26A666A468Fda8_0x4ceecae4047d731de541d672b864b5ef930a845df2e79713231f43cbdf974cd8