Skip to content

Improve code quality and linting fixes#746

Merged
yeasy merged 10 commits intohyperledger-cello:lab/kirin-refactorfrom
dodo920306:fix/code-quality
Feb 21, 2026
Merged

Improve code quality and linting fixes#746
yeasy merged 10 commits intohyperledger-cello:lab/kirin-refactorfrom
dodo920306:fix/code-quality

Conversation

@dodo920306
Copy link
Copy Markdown
Contributor

Summary

Fix code quality issues including Flake8 errors, unused variables, and organize Docker-related files.

Changes

Flake8 Fixes

  • Fix all Flake8 errors
  • Remove unused variables
  • Fix missing blank lines and redundant whitespace

Code Cleanup

  • Remove legacy peer-related code (api/lib/peer/)
  • Remove channel/configtx.py
  • Run Prettier formatting

Build Fixes

  • Fix make start command
  • Fix Fabric version URL
  • Temporarily comment out Newman tests

Docker File Organization

  • Move build_image/docker/cello-hlf/ to src/nodes/hyperledger-fabric/
  • Remove redundant Docker-related files
    • build_image/docker/agent/
    • build_image/docker/common/dashboard/
    • build_image/docker/common/nginx/
    • build_image/dockerhub/

Dependencies


🤖 This PR description was generated with AI assistance (Claude, Anthropic).

Signed-off-by: dodo920306 <dodo920306@gmail.com>
Signed-off-by: dodo920306 <dodo920306@gmail.com>
Signed-off-by: dodo920306 <dodo920306@gmail.com>
Signed-off-by: dodo920306 <dodo920306@gmail.com>
Signed-off-by: dodo920306 <dodo920306@gmail.com>
Signed-off-by: dodo920306 <dodo920306@gmail.com>
Signed-off-by: dodo920306 <dodo920306@gmail.com>
They will be added back once they're ready
for the new APIs

Signed-off-by: dodo920306 <dodo920306@gmail.com>
All dockerfiles should be directly placed inside with their
codes. By this way, it reduces the effort to pay attention
to connect them with their true codebase and context.

Signed-off-by: dodo920306 <dodo920306@gmail.com>
@dodo920306 dodo920306 marked this pull request as draft December 14, 2025 15:42
@dodo920306
Copy link
Copy Markdown
Contributor Author

This is draft only because #745 hasn't been merged yet.

This was referenced Dec 14, 2025
@dodo920306 dodo920306 changed the base branch from main to lab/kirin-refactor January 22, 2026 06:32
@dodo920306 dodo920306 marked this pull request as ready for review January 27, 2026 02:31
@dodo920306
Copy link
Copy Markdown
Contributor Author

@yeasy

@yeasy yeasy merged commit 24a01c9 into hyperledger-cello:lab/kirin-refactor Feb 21, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants